Skip to content

🐛 Fix race condition in Warmup unit test #3287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

🐛 Fix race condition in Warmup unit test #3287

merged 1 commit into from
Aug 18, 2025
+8 −1

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

Fixes https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-controller-runtime-test/1957046953783070720

WARNING: DATA RACE
Write at 0x00c0005aa030 by goroutine 796:
  sigs.k8s.io/controller-runtime/pkg/internal/controller.init.func3.1()
      /home/prow/go/src/github.com/kubernetes-sigs/controller-runtime/pkg/internal/controller/controller_test.go:80 +0x813
  github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3()
      /home/prow/go/pkg/mod/github.com/onsi/ginkgo/[email protected]/internal/node.go:475 +0x2e
  github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
      /home/prow/go/pkg/mod/github.com/onsi/ginkgo/[email protected]/internal/suite.go:894 +0x128
Previous read at 0x00c0005aa030 by goroutine 773:
  sigs.k8s.io/controller-runtime/pkg/internal/controller.init.func3.6.17.2()
      /home/prow/go/src/github.com/kubernetes-sigs/controller-runtime/pkg/internal/controller/controller_test.go:1422 +0xa4

@sbueringer
Copy link
Member Author

/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alvaroaleman,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4b00a38742096a56c3bf7bd468ae540e08ac0ba1

@k8s-ci-robot k8s-ci-robot merged commit f4303b0 into kubernetes-sigs:main Aug 18, 2025
11 checks passed
@sbueringer sbueringer deleted the pr-fix-race branch August 18, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@FillZpp FillZpp Awaiting requested review from FillZpp

@troy0820 troy0820 Awaiting requested review from troy0820

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbueringer @k8s-ci-robot @alvaroaleman